Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building a RAPTOR that uses lower bounds as goal direction
vector_map<route_idx_t, std::uint16_t> route_lb_, same thing for RT transports.route_lb_the stop is skipped (again we do the same thing for RT transports).versions so far:
Unit Tests
The implementation passes most unit tests for the vanilla RAPTOR. Current failures:
Evaluation on DELFI GTFS
Correctness
with interval extension:
fixed 2h search windows:
Performance: with array extension and min connection count = 5
baseline
response_time
average: 1,381.23
max: 37,397
99 quantile: 19,717
90 quantile: 3,227
80 quantile: 1,685
50 quantile: 352
min: 0
greedy
response_time
average: 663.49
max: 27,799
99 quantile: 5,231
90 quantile: 1,414
80 quantile: 796
50 quantile: 312
min: 1
more greedy
response_time
average: 691.30
max: 9,232
99 quantile: 4,581
90 quantile: 1,518
80 quantile: 964
50 quantile: 359
min: 2
Performance: 2h search windows and no min con count
baseline
response_time
average: 394.78
max: 4,868
99 quantile: 2,549
90 quantile: 1,080
80 quantile: 615
50 quantile: 155
min: 0
acceptable loss = 1.0 (i.e., no increase of lb accepted)
response_time
average: 228.58
max: 2,601
99 quantile: 1,195
90 quantile: 452
80 quantile: 292
50 quantile: 145
min: 0
acceptable loss = 1.42 (i.e., the lb may increase up until 42%)
response_time
average: 314.44
max: 3,797
99 quantile: 2,120
90 quantile: 839
80 quantile: 413
50 quantile: 135
min: 0
more greedy
response_time
average: 136.27
max: 703
99 quantile: 400
90 quantile: 223
80 quantile: 169
50 quantile: 109
min: 0
acceptable loss 1.42, threshold 60
response_time
average: 324.71
max: 3,858
99 quantile: 2,164
90 quantile: 848
80 quantile: 435
50 quantile: 146
min: 0